Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mail lambda custom message #235

Closed
wants to merge 4 commits into from
Closed

fix: mail lambda custom message #235

wants to merge 4 commits into from

Conversation

willmcvay
Copy link
Contributor

@willmcvay willmcvay commented Feb 11, 2020 •
edited
Loading

Fixes: #232
Fixes: #236
Fixes: #239

duong-se
duong-se suggested changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add nohoist for this packages to root package.json to add dependencies local for deployment

@duong-se
Copy link
Contributor

@willmcvay one more things we need to discuss is deployment pipeline tell that we lack of env.yml file when deploy, so do you have any idea?

@willmcvay willmcvay force-pushed the feat/custom-mailer-admin-create-user branch from 9d1418d to d8866f3 Compare February 12, 2020 09:00
@github-actions github-actions bot requested a review from duong-se February 12, 2020 09:01
duong-se
duong-se approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove

environment:
    COGNITO_USERPOOL_ID: ${self:custom.${self:provider.stage}.COGNITO_USERPOOL_ID}
    MARKET_PLACE_URL: ${self:custom.${self:provider.stage}.MARKET_PLACE_URL}

and

custom: ${file(./env.yml)}

in serverless.yml. Others is ok with me

@willmcvay willmcvay force-pushed the feat/custom-mailer-admin-create-user branch from d8866f3 to 5c2f207 Compare February 12, 2020 10:36
@github-actions github-actions bot added the config-manager Relates to Config Manager package label Feb 12, 2020
@github-actions github-actions bot requested a review from duong-se February 12, 2020 10:36
@willmcvay
Copy link
Contributor Author

pls remove

environment:
    COGNITO_USERPOOL_ID: ${self:custom.${self:provider.stage}.COGNITO_USERPOOL_ID}
    MARKET_PLACE_URL: ${self:custom.${self:provider.stage}.MARKET_PLACE_URL}

and

custom: ${file(./env.yml)}

in serverless.yml. Others is ok with me

@willmcvay willmcvay closed this Feb 12, 2020
@willmcvay willmcvay mentioned this pull request Feb 12, 2020
Merged
@willmcvay willmcvay deleted the feat/custom-mailer-admin-create-user branch February 12, 2020 11:14
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@trankhacvy
[CLD-575] Client welcome message (#235)
61afee5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@zlatanpham zlatanpham Awaiting requested review from zlatanpham

@duong-se duong-se Awaiting requested review from duong-se

Assignees

@willmcvay willmcvay

Labels
cognito-custom-mail-lambda config-manager Relates to Config Manager package
Projects
None yet
Milestone
No milestone
2 participants
@willmcvay @duong-se